Switch between files and refactorings #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
anchouls
commented
Apr 20, 2023
anchouls
commented
onewhl
requested changes
Apr 21, 2023
There was a problem hiding this comment.
@anchouls wow, it looks cool! And I noticed that you use new UI, that's also awesome!
I have a couple suggestions:
- Let's call it just "Refactorings", not "Refactoring Insights".
- Is it possible to add "Show" to the left of the drop-down list as it presented on the mockup?
|
Everything as it is shown on the mockup:
|
|
@anchouls awesome!! Thank you Anna, I will test it and merge then. |
onewhl
requested changes
Apr 21, 2023
.../src/main/java/org/jetbrains/research/refactorinsight/actions/ComboBoxRefactoringAction.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/jetbrains/research/refactorinsight/actions/ComboBoxRefactoringAction.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/jetbrains/research/refactorinsight/actions/ComboBoxRefactoringAction.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/jetbrains/research/refactorinsight/actions/ComboBoxRefactoringAction.java
Outdated
Show resolved
Hide resolved
onewhl
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.