New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
some minor rewordings #5
base: ctv
Are you sure you want to change the base?
Conversation
BIP-CTV: fix mistypes, omissions, etc
This are just minor changes, which do not impact the overall logic. I hope this is not too much at once.
bip-ctv.mediawiki
Outdated
@@ -244,27 +244,27 @@ Below we'll discuss the rules one-by-one: | |||
The set of data committed to is a superset of data which can impact the TXID of the transaction, | |||
other than the inputs. This ensures that for a given known input, the TXIDs can also be known ahead | |||
of time. Otherwise, CHECKTEMPLATEVERIFY would not be usable for Channel Factory type constructions | |||
as the redemption TXID could be malleated and pre-signed transactions invalidated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think malleated might have a specific meaning here (that probably should be elaborated on for clarity). So changing that word to "change" might not be the right thing here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that it is trying to refer to »transaction malleability« but it's the first time I've ever seen »malleated« and it just feels like change conveys the same meaning but is clearer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume so as well. I have seen other people use the word malleated as well in cases like this. You can see its commonality with a google search.
bip-ctv.mediawiki
Outdated
inputs. | ||
|
||
=====Committing to the Sequences Hash===== | ||
|
||
If we don't commit to the sequences, then the TXID can be malleated. This also allows us to enforce |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here - I would keep the word "malleated" here.
4cf129f
to
80b4ba6
Compare
added test vector #5 for invalid extended keys
This are just minor changes, which do not impact the overall logic. I hope this is not too much at once.