Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Post Python 3.10 bump, where relevant, use KW_ONLY sentinel values #372

Open
daniel-dodd opened this issue Aug 30, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@daniel-dodd
Copy link
Member

Feature Request

Post Python 3.10 bump #370, to avoid issues with default values, we should use the KW_ONLY, e.g., for names most notably this would be great for default kernel stuff like the computations, active_dims, that get in the way!

@dataclass
class AbstractKernel(Module):
    r"""Base kernel class."""
    _: KW_ONLY # <-------------- INTRODUCE HERE:
    compute_engine: AbstractKernelComputation = static_field(DenseKernelComputation())
    active_dims: Optional[List[int]] = static_field(None)
    name: str = static_field("AbstractKernel")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant