Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: Use kwargs only in dataclasses #421

Open
thomaspinder opened this issue Nov 28, 2023 · 1 comment
Open

dev: Use kwargs only in dataclasses #421

thomaspinder opened this issue Nov 28, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@thomaspinder
Copy link
Collaborator

Now that our minimum Python version is 3.10, we can make use of the kw_only argument in the dataclass constructor and remove the awkward None initialisation. To resolve this issue, the following steps would need to be taken

  1. Decorate all dataclasses with kw_only=True
  2. Remove all None argument defaults
  3. Cleanup the corresponding __post_init__
@thomaspinder thomaspinder added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Nov 28, 2023
@daniel-dodd
Copy link
Member

Tagging #372 as closely related issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thomaspinder @daniel-dodd