Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

call delegate '#getService()' when looking up single service #132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

theborakompanioni
Copy link

@theborakompanioni theborakompanioni commented Dec 5, 2020

as classes implementing ServiceProvider may define their own custom behaviour, let the ServiceProvider instance itself fetch a single service by name instead of using an own standard strategy (using the first one returned by #getServices(Class))

this way it is prevented that a ServiceProvider must load all services of the class even if they are not generellay needed (including all side effects e.g. loading data from remote services)


This change is Reviewable

as classes implementing `ServiceProvider` may define their own
custom behaviour, let the `ServiceProvider` instance itself fetch a single
service by name instead of using an own standard strategy (using the first one
returned by `#getServices(Class)`)

this way it is prevented that a `ServiceProvider` must load all services of the class
even if they are not generellay needed (including all side effects e.g. loading data
from remote services)
@keilw
Copy link
Member

keilw commented Dec 5, 2020

Are you a JCP member? Because we cannot accept PRs from non-members in the API, RI or TCK repositories. We just had a MR1, so it may be up to the next version, if you are able to join the JCP we'd be happy to accept the PR.

@keilw keilw added this to the .Next milestone Dec 5, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 78.212% when pulling dd4cc06 on theborakompanioni:master into 9f64034 on JavaMoney:master.

@theborakompanioni
Copy link
Author

Hey @keilw! Thanks for your response.
Unfortunately I cannot do that, as it requires an Oracle account, which I wont create (jcp.org accounts are integrated with Oracle's Single Sign-On (SSO) login mechanism).
Would it be possible to apply the changes in an other way, e.g. by adding them yourself?
I do not mind not being the author of the changes. You can do whatever you want. I hereby grant all power to you.

Thank you for your time and service.

@keilw keilw added the deferred label Dec 6, 2020
@keilw
Copy link
Member

keilw commented Dec 6, 2020

We have to see, the general mechanism is not different from other JSRs but it needs to wait till a really new JSR anyway.

@theborakompanioni
Copy link
Author

Any updates on this @keilw ?

@keilw
Copy link
Member

keilw commented Dec 5, 2021

No @theborakompanioni there is no new JSR so it'll have to wait.
We have to get the 3rd Spec Lead which was recently aqcuired by Accenture, so hard to say, if they are still interested and available for that kind of stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants