Added method to create a permanently tagged subtree

[martyglaubitz]

Whilst using timber i often found that i would rather be able to specify a permanent tag then relying on Timbers magic to compute the tag. Therefore i added this convinient method to do exactly that.

I don't expect this PR to be accepted right away and will add additional tests & docs when this even has a chance to be accepted in the main library project.

[JakeWharton]

I think I'd prefer to have the method called `tagged` instead. What do you think?

…

On Sat, Apr 15, 2017 at 9:44 AM Marty Glaubitz ***@***.***> wrote: Whilst using timber i often found that i would rather be able to specify a permanent tag then relying on Timbers magic to compute the tag. Therefore i added this convinient method to do exactly that. I don't expect this PR to be accepted right away and will add additional tests & docs when this even has a chance to be accepted in the main library project. ------------------------------ You can view, comment on, or merge this pull request online at: #224 Commit Summary - add: Timber.tagPermanent - add: Timber.tagPermanent tests File Changes - *M* timber/src/main/java/timber/log/Timber.java <https://github.com/JakeWharton/timber/pull/224/files#diff-0> (25) - *M* timber/src/test/java/timber/log/TimberTest.java <https://github.com/JakeWharton/timber/pull/224/files#diff-1> (20) Patch Links: - https://github.com/JakeWharton/timber/pull/224.patch - https://github.com/JakeWharton/timber/pull/224.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#224>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEEEXfcvvzgM8hvvq0716NeKpve2sraks5rwMmpgaJpZM4M-WhH> .

[JakeWharton]

Also calling .tag should be able to override this

[martyglaubitz]

@JakeWharton you're right, tagged makes more sense

[jgavazzisp]

👍 that would be very handy

[vanniktech]

@martyglaubitz will you pick this up again with the feedback?

[martyglaubitz]

@vanniktech now that there's quit some demand for this, i will

[eunicekokor]

Also adding some documentation in the README would help !

[martyglaubitz]

@eunicekokor yes you're right

[martyglaubitz]

@JakeWharton

Also calling .tag should be able to override this
Good point

[martyglaubitz]

@JakeWharton applied your suggestion

[skykelsey]

This would be really handy right now. Is this going to be merged? Alternatively, why not just remove the final modifier on DebugTree.getTag()?

[joshuadeguzman]

@JakeWharton is there by any chance that this will be merged?

[E3V3A]

...which is why you should merge stuff sooner and not 2 years later.

[budaowengd]

为啥没有永久性的Tag呢? 好惆怅

[jarrodmoldrich]

@JakeWharton @jrodbx Is this likely to be merged? Or is there some alternate way of doing this?

[JakeWharton]

I'd like it as a feature of the next major version. Right now any time I have to devote to the project is focused on the Kotlin port and subsequent support for multiplatform.

…

On Wed, Jun 12, 2019 at 10:02 PM Jarrod Moldrich ***@***.***> wrote: @JakeWharton <https://github.com/JakeWharton> @jrodbx <https://github.com/jrodbx> Is this likely to be merged? Or is there some alternate way of doing this? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#224?email_source=notifications&email_token=AAAQIEKYQGZ7GUUC2YWAKJ3P2GTEBA5CNFSM4DHZNBD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXSJK4Q#issuecomment-501519730>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAQIEMT247SE6JQUHXN4VTP2GTEBANCNFSM4DHZNBDQ> .