Skip to content

Commit

Permalink
chore(ci): automatically extract publisher and publisher name from si…
Browse files Browse the repository at this point in the history
…gning certificate
  • Loading branch information
JagandeepBrar committed May 13, 2023
1 parent d271412 commit 896f24f
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 9 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,6 @@ jobs:
secrets:
CODE_SIGNING_CERTIFICATE: ${{ secrets.CODE_SIGNING_CERTIFICATE }}
CODE_SIGNING_PASSWORD: ${{ secrets.CODE_SIGNING_PASSWORD }}
CODE_SIGNING_PUBLISHER: ${{ secrets.CODE_SIGNING_PUBLISHER }}
CODE_SIGNING_PUBLISHER_NAME: ${{ secrets.CODE_SIGNING_PUBLISHER_NAME }}

publish-android:
name: Publish Android
Expand Down
8 changes: 1 addition & 7 deletions .github/workflows/build_windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@ on:
required: true
CODE_SIGNING_PASSWORD:
required: true
CODE_SIGNING_PUBLISHER:
required: true
CODE_SIGNING_PUBLISHER_NAME:
required: true

jobs:
build-app-package:
Expand Down Expand Up @@ -49,9 +45,7 @@ jobs:
flutter pub run msix:create `
--certificate-password=${{ secrets.CODE_SIGNING_PASSWORD }} `
--certificate-path=${{ github.workspace }}/keys/codesigning.pfx `
--output-path=${{ github.workspace }}/output `
--publisher=${{ secrets.CODE_SIGNING_PUBLISHER }} `
--publisher-display-name=${{ secrets.CODE_SIGNING_PUBLISHER_NAME }}
--output-path=${{ github.workspace }}/output
- name: Upload Artifact
uses: actions/upload-artifact@v3
Expand Down

0 comments on commit 896f24f

Please sign in to comment.