Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try parallel tests #9797

Merged
merged 4 commits into from May 12, 2024
Merged

Try parallel tests #9797

merged 4 commits into from May 12, 2024

Conversation

koppor
Copy link
Member

@koppor koppor commented Apr 24, 2023

This PR applies https://docs.gradle.org/8.1/userguide/performance.html#execute_tests_in_parallel to our project.

NOT using the JUNIT parallelism (where we failed a few months ago), but trying gradle :)

More background: https://aahlenst.dev/blog/comparing-parallel-test-execution-in-junit5-gradle-maven/

Compulsory checks

Edit tasklist title
Beta Give feedback Tasklist Compulsory checks, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
    Options
  2. Tests created for changes (if applicable)
    Options
  3. Manually tested changed features in running JabRef (always required)
    Options
  4. Screenshots added in PR description (for UI changes)
    Options
  5. Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
    Options
  6. Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.
    Options

@koppor
Copy link
Member Author

koppor commented Apr 24, 2023

Other PR (#9703) without parallel:

image

Thus, parallelism doesn't bring anything. Don't know why. Let's investigate if we have more time for this.

@koppor koppor closed this Apr 24, 2023
@koppor koppor deleted the parallel-tests branch April 24, 2023 23:09
@koppor koppor restored the parallel-tests branch May 7, 2024 12:48
@koppor koppor reopened this May 7, 2024
@koppor
Copy link
Member Author

koppor commented May 7, 2024

image

@koppor
Copy link
Member Author

koppor commented May 7, 2024

image

Copy link
Contributor

github-actions bot commented May 7, 2024

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label May 7, 2024
@koppor
Copy link
Member Author

koppor commented May 7, 2024

No speed gain on GitHub, but locally huge performance improvement

@koppor koppor marked this pull request as ready for review May 7, 2024 22:13
@Siedlerchr Siedlerchr enabled auto-merge May 12, 2024 10:57
@Siedlerchr Siedlerchr added this pull request to the merge queue May 12, 2024
Merged via the queue into main with commit 71efec0 May 12, 2024
27 checks passed
@Siedlerchr Siedlerchr deleted the parallel-tests branch May 12, 2024 11:05
@koppor koppor mentioned this pull request May 17, 2024
6 tasks
Siedlerchr added a commit that referenced this pull request May 19, 2024
* upstream/main:
  Update latex citations status in JavaFx thread (#11302)
  Remove EnglishStemAnalyzer and use EnglishAnalyzer (#11301)
  Fix comment (#11299)
  Try gradle build speedup (#11300)
  Remove obsolete step (#11295)
  Bump com.fasterxml.jackson.dataformat:jackson-dataformat-yaml (#11290)
  Remove outdated pdf indexed files from Lucene index (#11293)
  Bump src/main/resources/csl-styles from `5338902` to `434df0a` (#11292)
  Bump org.mockito:mockito-core from 5.11.0 to 5.12.0 (#11291)
  Bump com.fasterxml.jackson.datatype:jackson-datatype-jsr310 (#11289)
  Bump com.dlsc.gemsfx:gemsfx from 2.12.0 to 2.16.0 (#11287)
  Bump org.openrewrite.recipe:rewrite-recipe-bom from 2.9.0 to 2.11.0 (#11288)
  Introduce formatter to remove word-enclosing braces (#11253)
  Try parallel tests (#9797)
  Store preview divider pos in entry editor (#11285)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-system status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants