Prototype Implement better Search #341 #8356
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and RegexBasedSearchRule
Add Lucene functionality to SearchBar
- Fixed odd behaviour where dropdown reapppears when repeatedly clicking search bar - Removed detachable attrubute (for now?) - Corrected Checkstyle - Added test method to author button (dont allow attributes without search terms)
- Fixed odd behaviour where dropdown reapppears when repeatedly clicking search bar - Removed detachable attrubute (for now?) - Corrected Checkstyle - Buttons dont allow adding attributes when prior ones are empty
Improved buttons
…into ChipView_prototype
Corrected some minor formatting errors
Also modified RecentSearch such that empty strings do not get added to the list.
# Conflicts: # src/main/java/org/jabref/gui/search/DropDownMenu.java
# Conflicts: # src/main/java/org/jabref/gui/search/DropDownMenu.java # src/main/java/org/jabref/gui/search/GlobalSearchBar.java # src/main/java/org/jabref/gui/search/SearchFieldSynchronizer.java # src/main/java/org/jabref/gui/search/SearchItem.java
2 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was to implement a better search #Issue 341. koppor#341
It was mentioned to implement something like this:
The following things have been added:
synchronizes with the GlobalSearchBar.
Recent Prototype looking like this:
Current problems:
Removed the ChipView prototype as it's not working.
Bracket logic (AND^-1/OR^-1) not working properly yet.
YearRange Slider input (yearrange:) doesn't search correctly.
Recent search also considers invalid search queries.
Change in
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (for UI changes)
Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.