Fix additionnal CURLOPT_HTTPHEADER bug #271
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Put, delete support, overriding of cURL options
When we add additionnal header in the call to the performRequest method like this :
$return_api = $this->twitter->buildOauth($url, $requestMethod)->performRequest(true, [
CURLOPT_HTTPHEADER => array('Content-Type:application/json'),
CURLOPT_POSTFIELDS => json_encode($postfields)
]);
Authentication data is not sent in the request, So we have this type of return :
{"errors":[{"code":215,"message":"Bad Authentication data."}]}
J7mbo
reviewed
Aug 20, 2018
| @@ -287,6 +287,13 @@ public function performRequest($return = true, $curlOptions = array()) | |||
| { | |||
| $curlOptions[CURLOPT_CUSTOMREQUEST] = $this->requestMethod; | |||
| } | |||
|
|
|||
| if (isset($curlOptions[CURLOPT_HTTPHEADER])) { | |||
There was a problem hiding this comment.
Minor thing here dude! Coding-standards-wise let's keep some consistency, so { on new lines and a blank line before the unset! :) Then, once the code is squashed into 1 commit, I'll merge! Thanks 👍
|
Once you've done this, if you don't want to do it yourself, I'm going to write a test for the problem that the original user came up with and put it into develop, then merge develop in as 1.07. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.