Skip to content

IvanPostarnak/smart-home-markup-training

Folders and files

NameName
Last commit message
Last commit date

Latest commit

 

History

29 Commits
 
 
 
 
 
 

Repository files navigation

"Smart Home" markup training 💪

smart-home-presentation-picture Example of markup training
The THIRD markup of mine, a little better than the previous ones


Mistakes of my very first try ㊙️

  • a lot of repetitions of CSS code
  • not using BEM methodology of CSS
  • not using any of CSS preprocessors
  • was not using semantic tags of HTML at all
  • it wasn't checked in every browser it should've been checked in
  • didn't set copyrights, author or description meta
  • was not using power of inheritance

In the previous (second) attempt there were such mistakes as 🉐

  • still a lot of repetitions of CSS code
  • not using any of CSS preprocessors
  • not cross-browser support

Things I've achieved in markup by this moment:

  • I've added semantic tags of HTML, such as <header>, <nav>, <section>, <article>, <aside>, <footer> and <address>
  • using only one of each <h1> - <h6> headers (with one exception)
  • add <meta name="author"> and <meta name="description">, as well as commented copyrights into html file
  • using oblique isntead of italic
  • using webp image format instead of png in the previous examples (wanted to use svg as well)
  • set font-size relatively, based on the :root { font-size: 10px; } (math with 10px is much easier than with 14px or 16px)
  • started using SCSS preprocessor of CSS, including $preprocessor-directive and @import './relative/path/scss-module-name'
  • organize modules and project structure according to the BEM methodology (+-)
  • started using <a> tag insted of <button> one for elements such as "See more", "Read More" etc
  • partly using BEM (not perfectly)
  • partly achieved full cross-browser support
    • Google Chrome ✔️
    • Mozilla Firefox ✔️
    • Microsoft Edge ✔️
    • Internet Explorer ❌
    • Safari ❔
  -webkit-box-sizing: border-box;
  -moz-box-sizing: border-box;
  -ms-box-sizing: border-box;
  -o-box-sizing: border-box;
  box-sizing: border-box;

New things to improve: ❗

  • don't forget about <main> semantic tag
  • use svg format for icons
  • add .gitignore and ignore .css.map building files
  • check mixins and predicate operators of SCSS
  • use <noscript> html tag
  • keep honing BEM methodology

Contacts

About

Just another one completed markup (just for training, and fun =)

Topics

Resources

Stars

Watchers

Forks