[MOB-5473] Embedded GA Release #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[MOB-5746] payload fields
Anelson/fix elements button action
wrap embedded messages payload
…reground-retrieval
[MOB-5969] stop when logged out
[MOB-5964] foreground retrieval
# Conflicts: # tests/unit-tests/InAppHelperTests.swift
[MOB-5845] auto fetch boundary
[MOB-5973] route rename
# Conflicts: # swift-sdk/IterableAPI.swift
Version 6.5.0 alpha1
[MOB-6132] manual override refresh
[MOB-7679] Updates OOTB constraints
Matching the android's OOTB behaviour where Title and body are top aligned instead of being in center when displayed in banner view
By keeping the height of the stackview that holds the button equal to the button's height.
Image to title space optimized
Title and description texts can now reach till the image start if they exist or till the container's end
[MOB-7733] doesn't fetch embedded messages by default, adds a config option
davidtruong
changed the title
Ayyanchira
reviewed
Jan 29, 2024
| @@ -0,0 +1,183 @@ | |||
| # UI Components provided by IterableSDK | |||
|
|
|||
| ## IterableBannerView for iOS | |||
There was a problem hiding this comment.
We will be providing the doc in the code for the first time like this. cc @bradumbaugh.
Do we want that approach?
Ayyanchira
reviewed
Jan 29, 2024
| Build and run your project to see the IterableBannerView in action on your device or simulator. | ||
|
|
||
| ## Video Preview | ||
| <!--  --> |
There was a problem hiding this comment.
An mp4 video within SDK? Not sure about this @davidtruong what do you think?
Ayyanchira
reviewed
Jan 29, 2024
BannerViewDocuments/Property.jpg
Outdated
There was a problem hiding this comment.
Xib inspectables are also kind of removed now.. might have to remove this image
Ayyanchira
reviewed
Jan 29, 2024
BannerViewDocuments/Sample3.jpg
Outdated
There was a problem hiding this comment.
Great sample images to though..
Ayyanchira
reviewed
Jan 29, 2024
There was a problem hiding this comment.
Hmm. not sure if we are using this file anywhere.. have to revisit
Ayyanchira
reviewed
Jan 29, 2024
There was a problem hiding this comment.
This file has been visited previously during the last sprints. Looks good
Ayyanchira
reviewed
Jan 29, 2024
[MOB-XXXX] updates changelog and removes banner view documents directory
Placing a `less than equal to` constraint so that when image is not present, the nil image can provide its width for stackview beside it
Image in banner view to have constant width of 100 if its available. If not, the flexible constraint view can shrink the size of imgView making it available to stackview when image is not present
…View [MOB-7748] iOS constraints fix for banner img view
# Conflicts: # README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔹 Jira Ticket(s)
✏️ Description
GA ready embedded build branch