fix: the wrong text is inserted after uploading an image #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ionaru
reviewed
Feb 17, 2024
| @@ -878,18 +878,10 @@ function afterImageUploaded(editor, url) { | |||
| var cm = editor.codemirror; | |||
| var stat = getState(cm); | |||
| var options = editor.options; | |||
| // TODO: Get the image name from the original file name | |||
There was a problem hiding this comment.
Is this TODO something that needs to be added to this PR?
There was a problem hiding this comment.
No. If we want to add this feature, it will be a breaking change for the current API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolves #334. Resolves #574.
❓ Type of change
📚 Description
The original code inserted a link text after uploading the image. This pull request will correct it and ensure that the image name is respected when the file extension is included, particularly for known image extensions.