-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug with compromised tests #144
base: develop
Are you sure you want to change the base?
Fix bug with compromised tests #144
Conversation
@Invictum hi. How are you? Any updates? =) |
@Invictum any updates? |
@Invictum Hey, how are you? |
@Invictum Are you still here? |
Hi @Invictum. How are you? |
Hi @Invictum and @grey-rain could you merge my PR. This would help us to remove our internal version and start updating version of integration. Thanks. |
@@ -18,7 +18,7 @@ | |||
* Common test recorder suitable for most cases | |||
*/ | |||
public class Regular extends TestRecorder { | |||
static final int RETRIES_COUNT = ReportIntegrationConfig.get().retriesCount(); | |||
final int RETRIES_COUNT = ReportIntegrationConfig.get().retriesCount(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as it is not a constant anymore, please rename it to camelCase. Could you please provide any insights about why this change was required BTW? :)
I do not mind changing it, just want to understand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We found that compromised tests could be executed by JUnit twice and duplicated in the Report Portal. This fix should help with this.
Before:
After: