Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Charging Bench #2

Closed
wants to merge 5 commits into from
Closed

Conversation

Intybyte
Copy link
Owner

@Intybyte Intybyte commented May 3, 2024

Description

Making ChargingBench rechargeable only ItemStacks with 1 items

Proposed changes

By adding this feature addon makers can make heir own Rechargeable any item they want and not be limited to tools

Related Issues (if applicable)

Resolves Slimefun#4183

Checklist

  • [V] I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • [V] I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • [V] I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • [V] I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

Sfiguz7 and others added 5 commits March 6, 2024 20:59
Co-authored-by: Daniel Walsh <walshydev@gmail.com>
* Actually check if the negative tests do their job

* Changed comments

* walshys suggestion

---------

Co-authored-by: JustAHuman-xD <65748158+JustAHuman-xD@users.noreply.github.com>
@Intybyte Intybyte closed this May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants