Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying a condition for pydantic v2 support. #169

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bmoore
Copy link
Contributor

@bmoore bmoore commented Oct 26, 2023

in regards to #150 I am getting warnings about the field_validator. I'm not sure if we want to have some future proofing around the validator warning. This change cleans up the warning I get from testing when using Pydantic v2

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #169 (87150c0) into main (88e08fa) will decrease coverage by 1.6%.
The diff coverage is 63.6%.

@@           Coverage Diff            @@
##             main    #169     +/-   ##
========================================
- Coverage   100.0%   98.4%   -1.6%     
========================================
  Files           6       6             
  Lines         247     253      +6     
========================================
+ Hits          247     249      +2     
- Misses          0       4      +4     
Files Coverage Δ
fastapi_azure_auth/user.py 94.1% <63.6%> (-5.9%) ⬇️

@JonasKs
Copy link
Member

JonasKs commented Oct 26, 2023

Thank you 😊 I think we can start dropping v1 support, so no need to keep v1 validators.

I will have more time mid November, and hope to have a pydantic v2-only release out in December.

@JonasKs
Copy link
Member

JonasKs commented Mar 4, 2024

Sorry for the long delay on this one.

I would like to:

  • Remove all token v1 support
  • Only support Pydantic v2 for new releases

This should increase the maintainability of this packge.

I thought I'd ask you whether you would like to help/review, or if I should go ahead myself. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants