Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update mdx files-try1 #130

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mohsspark829
Copy link

Hope this works:)

@mohsspark829
Copy link
Author

Hi there, seems some tests are failing although I have not touched any code. However, if it is easier I have uploaded the changes to my Google drive here:

Google drive

Changes includes two mdx files for single-tenant and multi-tenant folders.

About 8 new screenshots are that are in the static folder.

Thanks once again.
https://github.com/mohsspark829/fastapi-azure-auth/tree/Updated_mdx_with_one_app

@JonasKs
Copy link
Member

JonasKs commented Apr 14, 2023

I'll fix tests, thanks 😊

@mohsspark829
Copy link
Author

Hi there, Thanks, happy to PR as well. Just please let me know when the issues are fixed:)

@JonasKs
Copy link
Member

JonasKs commented Mar 4, 2024

First of all, I'm sorry for the delay on this one @mohsspark829. I'd like to look over them, but I honestly can't figure out what the intent behind these PRs were (and the difference between this and #128) - even though I know we talked about it back then.

Could you give me a brief summary, and I'll make sure to read through everything first thing?

Also, all tests in main are finally fixed. In other words, if you merge main into your branch, the pipelines should pass. If you need help with this, please let me know 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants