Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Add Conway governance tests #1695

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sgillespie
Copy link
Contributor

@sgillespie sgillespie commented May 7, 2024

Description

This adds some basic Conway governance tests mentioned in #1572. Note that we're only adding 2 tests here:

  • DRep registration/vote delegation/drep distribution
  • Electing a CC member

So this is far from complete, but should be enough to get us started on other features.

Checklist

  • Commit sequence broadly makes sense
  • Commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the changelog
  • Code is formatted with fourmolu on version 0.10.1.0 (which can be run with scripts/fourmolize.sh)
  • Self-reviewed the diff

Migrations

  • The pr causes a breaking change of type a,b or c
  • If there is a breaking change, the pr includes a database migration and/or a fix process for old values, so that upgrade is possible
  • Resyncing and running the migrations provided will result in the same database semantically

If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.

@sgillespie sgillespie force-pushed the test/conway-governance branch 3 times, most recently from dcab192 to 8e5b22f Compare May 15, 2024 18:29
@sgillespie sgillespie force-pushed the test/conway-governance branch 2 times, most recently from 4e5cdf2 to 3f6e543 Compare May 20, 2024 21:11
@sgillespie sgillespie force-pushed the test/conway-governance branch 2 times, most recently from b7220bd to d9074bd Compare May 21, 2024 14:29
@sgillespie sgillespie marked this pull request as ready for review May 21, 2024 17:34
Cmdv
Cmdv previously approved these changes May 21, 2024
Copy link
Contributor

@Cmdv Cmdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants