Save the DRep Pulser State after computing it #1687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgillespie
force-pushed
the
feature/save-drep-pulser
branch
from
a76f021
to
b04a0eb
Compare
kderme
reviewed
May 1, 2024
| -- of the cardano-ledger/ouroboros-consensus public APIs, because ledger state is not | ||
| -- designed to be updated this way. We are only replaying the chain, so this should be | ||
| -- safe. | ||
| class HasNewEpochState era where |
There was a problem hiding this comment.
That's a very useful class to have, which can be reused for https://github.com/orgs/IntersectMBO/projects/8/views/3?pane=issue&itemId=60533809
kderme
previously approved these changes
May 1, 2024
It can't be tested in preprod or preview right? Also, I forgot to update the comment, I have done some basic manual testing in sanchonet |
sgillespie
force-pushed
the
feature/save-drep-pulser
branch
from
b04a0eb
to
e3f5cc2
Compare
Right, it would only work on sanchonet after rebasing to master |
Yes, this is how I was able to test it on sanchonet. I applied my changes on top of |
sgillespie
force-pushed
the
feature/save-drep-pulser
branch
2 times, most recently
from
772c054
to
ecdbe06
Compare
This class can be used to get/update the underlying extended ledger state
Before retrieving the DRep pulsing state, force its evaluation, then save it to the ledger state. This will prevent us from unnecessarily recalculating it.
sgillespie
force-pushed
the
feature/save-drep-pulser
branch
from
ecdbe06
to
e1f7472
Compare
Cmdv
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1599. The bulk of this work is done in the
HasNewEpochStatetypeclass, which allows us to update the ledger state inExtLedgerState.Checklist
fourmoluon version 0.10.1.0 (which can be run withscripts/fourmolize.sh)Migrations
If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.