Make it build with ghc-9.8 #1636
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikd
force-pushed
the
erikd/ghc-9.8
branch
3 times, most recently
from
f3dfd9b
to
eaf6be1
Compare
sgillespie
previously approved these changes
Mar 6, 2024
erikd
force-pushed
the
erikd/ghc-9.8
branch
4 times, most recently
from
979c186
to
cf094ca
Compare
9 tasks
erikd
force-pushed
the
erikd/ghc-9.8
branch
5 times, most recently
from
de458bc
to
3b32195
Compare
This should really only be ghc96, but for now we'll keep 810 until all of the cardano codebase has dropped 8.10. Arguably none of this should be in here to begin with. The shell should come from the devx shell.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make it build with ghc-9.8
Checklist
fourmoluon version 0.10.1.0 (which can be run withscripts/fourmolize.sh)Migrations
If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.