Rmk16 remove tedit special stuff from CLIPBOARD, move it to TEDIT-COMMAND. #1676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also implements a different way of dealing with image objects in the selection. Instead of causing an error (since an imageobject can't be printed to the clipboard stream), it tries to put out a useful representation of the object. If the object has a preprint function, it applies that. Otherwise, it prints out the name of the getfn. Other objects can be explored.
|
Looks as though rmk15 and rmk16 have a conflict over changes to TEDIT-COMMAND ? I can't merge rmk16 into a test branch after I've merged rmk15. |
|
I tried to close/delete rmk15, rmk16 is a replacement.
… On Apr 21, 2024, at 1:51 PM, Nick Briggs ***@***.***> wrote:
Looks as though rmk15 and rmk16 have a conflict over changes to TEDIT-COMMAND ? I can't merge rmk16 into a test branch after I've merged rmk15.
—
Reply to this email directly, view it on GitHub <#1676 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJNTS5L754GG5PN7C7LY6QRGJAVCNFSM6AAAAABGRTTUROVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRYGE4TIMZUHE>.
You are receiving this because you authored the thread.
|
|
Ah, I see the problem - the PR was closed but the branch wasn't deleted, you have to do that explicitly on the https://github.com/Interlisp/medley/branches page. I've deleted the rmk15... branch. |
masinter
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also tries to put out a useful representation of image objects rather than just causing an error because an object is not a character code that can be printed to the clipboard stream. It applies the object's preprintfn, if there is one, otherwise prints the name of the getfn.
This isolates the issue in one place, as a first approximation. In the long run it might be possible to shadow the system clipboard with a local tmp file, and separately run the object's PUTFN to that file. Then copy/paste could move objects (with binary data) as well as characters from one place in Medley to another--or from one Medley image to another. We would need some way of keeping the clipboard and its shadow in sync as other applications or other Medleys make use of the clipboard.
If other consumers of the system clipboard respect some sort of convention for ignoring byte-runs, we could just put our additional information there and not deal with synchronization. Unlikely.