Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default prc menu shows all open PRs, draft and nondraft #1638

Closed

Conversation

rmkaplan
Copy link
Contributor

@rmkaplan rmkaplan commented Apr 2, 2024

No description provided.

@MattHeffron
Copy link
Contributor

It seemed an interesting challenge to get the information in JSON, and then to convert it into lisp.
This probably will not behave well if the PR description contains a "
I think I know how to fix that if necessary.

@rmkaplan
Copy link
Contributor Author

rmkaplan commented Apr 30, 2024 via email

@MattHeffron
Copy link
Contributor

I’ve written a first-pass JSON parser (I think).

I found the YASON implementation of a JSON parser/encoder in Common Lisp. I got the parser to load and compile. (The encoder uses CLOS heavily; I didn't try. I was able to code-around the CLOS in the parser.)
When I looked again at gh using jq, I realized that the "GO templates" were what I used a lot in the bibliography processing, so it seemed easier to switch to what I was familiar with.

@rmkaplan
Copy link
Contributor Author

rmkaplan commented May 2, 2024

As we agreed on Monday, I am closing and deleting this PR in favor of the JSON approach in #1689

@rmkaplan rmkaplan closed this May 2, 2024
@rmkaplan rmkaplan deleted the rmk5--GITFNS-defaults-to-all-PRs-including-drafts branch May 2, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants