Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emscripten/wasm does not support getrusage() system call #490

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

nbriggs
Copy link
Collaborator

@nbriggs nbriggs commented Feb 12, 2024

Updating the MiscStats data can at best provide the time of day and attribute all elapsed time to total CPU time.

Closes issue #1537

Updating the MiscStats data can at best provide the time of day and
attribute all elapsed time to total CPU time.

Closes issue #1537
Copy link
Collaborator

@fghalasz fghalasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tried it out online. Console msgs gone and functionality seems unchanged.

Copy link
Contributor

@waywardmonkeys waywardmonkeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an addendum, this isn't something that can be picked up via a configuration time check since emscripten does implement the function and everything at the level which is externally visible. (Since this is really part of musl which then makes a syscall which emscripten just stubs out.)

@nbriggs nbriggs merged commit 895f765 into master Feb 14, 2024
7 checks passed
@nbriggs nbriggs deleted the nhb-no-wasm-getrusage branch May 22, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants