Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review of User Guides section #1663

Merged
merged 5 commits into from
May 13, 2024
Merged

Review of User Guides section #1663

merged 5 commits into from
May 13, 2024

Conversation

bdmoore1
Copy link
Contributor

@bdmoore1 bdmoore1 commented May 4, 2024

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?
    InfoDev Review of User Guides content.

@bdmoore1
Copy link
Contributor Author

bdmoore1 commented May 4, 2024

@ndgrigorian please add you and @oleksandr-pavlyk as reviewers.

@coveralls
Copy link
Collaborator

coveralls commented May 4, 2024 •
edited

Coverage Status

coverage: 87.948% (+0.06%) from 87.892%
when pulling b69610b on bdmoore1:bdmoore1-userguides-review
into 0cb2181 on IntelPython:master.

@bdmoore1
Copy link
Contributor Author

bdmoore1 commented May 6, 2024

@oleksandr-pavlyk do you know why the LLVM CI test is failing?

@oleksandr-pavlyk
Copy link
Collaborator

@oleksandr-pavlyk do you know why the LLVM CI test is failing?

Sporadic test failure. It is a known issue. I restarted the workflow which should clear it up

ndgrigorian
ndgrigorian previously approved these changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that nit this LGTM

@bdmoore1 @ndgrigorian
Update docs/doc_sources/user_guides/environment_variables.rst
59f1912 
Co-authored-by: ndgrigorian <46709016+ndgrigorian@users.noreply.github.com>
ndgrigorian
ndgrigorian previously approved these changes May 11, 2024
View reviewed changes
@bdmoore1 @oleksandr-pavlyk
Update docs/doc_sources/user_guides/basic_concepts.rst
f451e6e 
Co-authored-by: Oleksandr Pavlyk <oleksandr.pavlyk@intel.com>
@bdmoore1 @oleksandr-pavlyk
Update docs/doc_sources/user_guides/execution_model.rst
b69610b 
Co-authored-by: Oleksandr Pavlyk <oleksandr.pavlyk@intel.com>
oleksandr-pavlyk
oleksandr-pavlyk approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @bdmoore1 !

@ndgrigorian ndgrigorian merged commit 4ae78d8 into IntelPython:master May 13, 2024
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk approved these changes

@ndgrigorian ndgrigorian ndgrigorian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bdmoore1 @coveralls @oleksandr-pavlyk @ndgrigorian