New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meta data improvements #1660

Open

ZzEeKkAa wants to merge 10 commits into master from feature/pyproject

Collaborator

ZzEeKkAa commented May 2, 2024 •

edited

Changes in this PR:

Move all supported configuration to pyproject.toml from setup.py and setup.cfg (latest one was removed).
Populate additional fields to project and build-system sections of pyproject.toml.
Use build packages from pyproject's build-system section in the conda meta.yaml to keep it in sync.
Use package managed versioneer.

Problems:

wheel package removes symbolic links

Checklist:

Have you provided a meaningful PR description?
Have you added a test, reproducer or referred to an issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
Have you checked performance impact of proposed changes?
If this PR is a work in progress, are you opening the PR as a draft?

ZzEeKkAa force-pushed the feature/pyproject branch 5 times, most recently from 020e55b to 1e7a526 Compare

May 2, 2024 22:01

Collaborator

coveralls commented May 2, 2024 •

edited

coverage: 87.892%. remained the same
when pulling 3d51b7c on feature/pyproject
into 0df3bec on master.

github-actions bot commented May 2, 2024 •

edited

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1660/index.html

github-actions bot commented May 2, 2024

Array API standard conformance tests for dpctl=0.17.0dev0=py310ha798474_322 ran successfully.
Passed: 870
Failed: 8
Skipped: 92

1 similar comment

github-actions bot commented May 2, 2024

Array API standard conformance tests for dpctl=0.17.0dev0=py310ha798474_322 ran successfully.
Passed: 870
Failed: 8
Skipped: 92

ZzEeKkAa requested a review from oleksandr-pavlyk

May 3, 2024 14:12

ZzEeKkAa force-pushed the feature/pyproject branch from 3d51b7c to dbb731a Compare

May 3, 2024 20:42

github-actions bot commented May 3, 2024

Array API standard conformance tests for dpctl=0.17.0dev0=py310ha798474_323 ran successfully.
Passed: 870
Failed: 8
Skipped: 92

ZzEeKkAa force-pushed the feature/pyproject branch 3 times, most recently from 6947845 to 54dbe67 Compare

May 4, 2024 04:42

github-actions bot commented May 4, 2024

Array API standard conformance tests for dpctl=0.17.0dev0=py310ha798474_334 ran successfully.
Passed: 870
Failed: 8
Skipped: 92

ZzEeKkAa force-pushed the feature/pyproject branch from 54dbe67 to 6d7d79e Compare

May 4, 2024 05:02

github-actions bot commented May 4, 2024

Array API standard conformance tests for dpctl=0.17.0dev0=py310ha798474_334 ran successfully.
Passed: 870
Failed: 8
Skipped: 92

1 similar comment

github-actions bot commented May 4, 2024

Array API standard conformance tests for dpctl=0.17.0dev0=py310ha798474_334 ran successfully.
Passed: 870
Failed: 8
Skipped: 92

ZzEeKkAa force-pushed the feature/pyproject branch from 6d7d79e to 1d87bae Compare

May 4, 2024 05:31

github-actions bot commented May 4, 2024

Array API standard conformance tests for dpctl=0.17.0dev0=py310ha798474_334 ran successfully.
Passed: 870
Failed: 8
Skipped: 92

ZzEeKkAa force-pushed the feature/pyproject branch from 1d87bae to c5fe610 Compare

May 4, 2024 05:41

github-actions bot commented May 4, 2024

Array API standard conformance tests for dpctl=0.17.0dev0=py310ha798474_334 ran successfully.
Passed: 870
Failed: 8
Skipped: 92

1 similar comment

github-actions bot commented May 4, 2024

Array API standard conformance tests for dpctl=0.17.0dev0=py310ha798474_334 ran successfully.
Passed: 870
Failed: 8
Skipped: 92

ZzEeKkAa force-pushed the feature/pyproject branch from c5fe610 to 57935b6 Compare

May 4, 2024 14:17

github-actions bot commented May 4, 2024

Array API standard conformance tests for dpctl=0.17.0dev0=py310ha798474_334 ran successfully.
Passed: 870
Failed: 8
Skipped: 92

oleksandr-pavlyk reviewed

View reviewed changes

pyproject.toml Show resolved Hide resolved

oleksandr-pavlyk reviewed

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

oleksandr-pavlyk mentioned this pull request

Development via pip install -e . #213

Closed

oleksandr-pavlyk reviewed

View reviewed changes

conda-recipe/build.sh Outdated Show resolved Hide resolved

oleksandr-pavlyk reviewed

View reviewed changes

conda-recipe/build.sh

+              CMAKE_ARGS="${CMAKE_ARGS} -DDPCTL_LEVEL_ZERO_INCLUDE_DIR=${PREFIX}/include/level_zero"
+              # -wnx flags mean: --wheel --no-isolation --skip-dependency-check
+              ${PYTHON} -m build -w -n -x

Collaborator

oleksandr-pavlyk May 22, 2024

Can we use python -m wheel unpack, remove copies of libDPCTLSyclInterface.so* and pack it back?

Collaborator Author

ZzEeKkAa May 29, 2024

Then numba_dpex won't link to those libraries for wheel install.

ZzEeKkAa added 10 commits

May 29, 2024 13:02


          Add pyproject format pre-commit

ac3e377


          Switch project meta to pyproject.toml

52a0299


          Use versioneer as build dependency

33ed2a0


          Clean up setup.py

ad0c4fe


          Improve error messages in cmake

9996daf


          Use conda distibuted level-zero package

cd3acc4


          Use conda distibuted pybind11 package

ddc8ede


          Add ZzEeKkAa to conda recipe mainteiner list

15497b5


          Use manylinux_2_28 wheel format

b722aa1


          Update docs dependencies

b043ab9

ZzEeKkAa force-pushed the feature/pyproject branch from 57935b6 to b043ab9 Compare

May 29, 2024 19:13

ZzEeKkAa marked this pull request as ready for review

May 29, 2024 19:15

github-actions bot commented May 29, 2024

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_38 ran successfully.
Passed: 890
Failed: 11
Skipped: 91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment