Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Use itkOverrideGetNameOfClassMacro as per ITK PR 4373 #155

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dzenanz
Copy link
Member

@dzenanz dzenanz commented Jan 25, 2024

See related ITK PRs:
InsightSoftwareConsortium/ITK#4373
InsightSoftwareConsortium/ITK#4378

We should probably wait until ITK 5.4 final is tagged, before merging this.

@dzenanz
Copy link
Member Author

dzenanz commented Jan 25, 2024

@dzenanz
Copy link
Member Author

dzenanz commented Jan 25, 2024

As-is, this breaks the python builds with GitHub action for remote modules:

[9/17] Generating /work/ITK-cp38-cp38-manylinux_2_28_x64/Wrapping/castxml_inputs/itkANTSRegistration.xml
FAILED: /work/ITK-cp38-cp38-manylinux_2_28_x64/Wrapping/castxml_inputs/itkANTSRegistration.xml 
cd /work/_skbuild/linux-x86_64-3.8/cmake-build/Wrapping/Modules/ANTsWasm && /work/_skbuild/linux-x86_64-3.8/cmake-build/Wrapping/Generators/CastXML/castxml/bin/castxml -o /work/ITK-cp38-cp38-manylinux_2_28_x64/Wrapping/castxml_inputs/itkANTSRegistration.xml --castxml-gccxml --castxml-start _wrapping_ --castxml-cc-gnu "(" /opt/rh/gcc-toolset-11/root/bin//g++ -std=c++14 ")" -w -c @/work/ITK-cp38-cp38-manylinux_2_28_x64/Wrapping/castxml_inputs/.castxml.inc /work/ITK-cp38-cp38-manylinux_2_28_x64/Wrapping/castxml_inputs/itkANTSRegistration.cxx
In file included from /work/ITK-cp38-cp38-manylinux_2_28_x64/Wrapping/castxml_inputs/itkANTSRegistration.cxx:16:
/work/include/itkANTSRegistration.h:66:3: error: unknown type name 'itkOverrideGetNameOfClassMacro'
  itkOverrideGetNameOfClassMacro(ANTSRegistration);
  ^
1 error generated.
ninja: build stopped: subcommand failed.

@jhlegarreta
Copy link
Member

I assume we would get a better sense of what's going on after the ITK commit hashes are updated in the CI config file:
https://github.com/InsightSoftwareConsortium/ITKModuleTemplate/blob/main/.github/workflows/build-test-package.yml#L6-L8

So:

We should probably wait until ITK 5.4 final is tagged, before merging this.

Looks the way forward to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants