Allow S3 public bucket configuration in project settings #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Thank you for your contribution. Sorry, it slipped through my radar. I'll review this tomorrow. |
|
actually today lol sory again |
|
Still working on it. It has quite a few repercutions... |
garronej
added a commit
that referenced
this pull request
Jun 1, 2024
|
Hey @slim0, It's finaly completed Screen.Recording.2024-05-31.at.21.58.06.movThere is a new entry in XOnyxia:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we already discussed that with you but we would like to configure a public bucket on the project settings (without giving access key id and secret).
I found this workaround on an issue in the aws-sdk library to send an anonymous request. I tried it and it works on my side on a public bucket we have.
Could you please take a look at this PR and let me know.
Thx