Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create fixing-issues-step-by-step.md #503

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Trueblueaddie
Copy link
Contributor

No description provided.

@spier spier added the 📖 Type - Content Work Working on contents is the main focus of this issue / PR label Dec 5, 2022
@robtuley
Copy link
Collaborator

Hi @Trueblueaddie --

Thanks for the contribution! I think I understand the main thrust of the pattern here -- use continuous improvement, a series of small rather than 1 big step -- but what I'm not getting from the pattern as written is how and why this is particularly related to InnerSource?

Maybe this is related to the incubator approach? i.e. start small, incubate through a series of small steps?

I think this needs to have a more InnerSource related angle if possible.

@spier
Copy link
Member

spier commented Mar 11, 2023

Hi @Trueblueaddie --

Thanks for the contribution! I think I understand the main thrust of the pattern here -- use continuous improvement, a series of small rather than 1 big step -- but what I'm not getting from the pattern as written is how and why this is particularly related to InnerSource?

Maybe this is related to the incubator approach? i.e. start small, incubate through a series of small steps?

I think this needs to have a more InnerSource related angle if possible.

@fioddor I have the same question that @robtuley raised above in that I don't see how this pattern is describing a specific InnerSource problem. What are your thoughts here?

@fioddor
Copy link
Contributor

fioddor commented Mar 11, 2023

Hi @Trueblueaddie --
Thanks for the contribution! I think I understand the main thrust of the pattern here -- use continuous improvement, a series of small rather than 1 big step -- but what I'm not getting from the pattern as written is how and why this is particularly related to InnerSource?
Maybe this is related to the incubator approach? i.e. start small, incubate through a series of small steps?
I think this needs to have a more InnerSource related angle if possible.

@fioddor I have the same question that @robtuley raised above in that I don't see how this pattern is describing a specific InnerSource problem. What are your thoughts here?

Summarized: small bits foster external contributions, @spier

I tried injecting more clues into the text (approvals pending), but if you still don't see it, it's a sign that we need to keep on clarifying.

spier and others added 2 commits March 11, 2023 15:25
Co-authored-by: Igor Zubiaurre <fioddor@gmail.com>
Co-authored-by: Igor Zubiaurre <fioddor@gmail.com>
@spier
Copy link
Member

spier commented Mar 11, 2023

@fioddor describing how an "Release early, release often" approach can attract more external contributors to your project sounds like a pattern indeed. How to do reviews in a way that they keep quality high while still being fast (enough) and motivating for the contributors would be super interesting as well.

Right now the pattern sounds it is talking about two different things:
On one hand it talks about "process changes". One the other hand there is something related to deadlines and splitting software development into smaller incremental steps.
Somehow it seems like both points don't really belong together? I am not sure.

Is it possible that Addie and you were actually after two separate ideas here?

@fioddor
Copy link
Contributor

fioddor commented Mar 12, 2023

@fioddor describing how an "Release early, release often" approach can attract more external contributors to your project sounds like a pattern indeed. How to do reviews in a way that they keep quality high while still being fast (enough) and motivating for the contributors would be super interesting as well.

Right now the pattern sounds it is talking about two different things: On one hand it talks about "process changes". One the other hand there is something related to deadlines and splitting software development into smaller incremental steps. Somehow it seems like both points don't really belong together? I am not sure.

Is it possible that Addie and you were actually after two separate ideas here?

I couldn't find anything about "process changes" beyond the suggested change of processing in smaller bits, @spier (?). So I don't see two conflicting points.

The patlet talks about ignoring "scope of change to process" and thereby being unrealistic about deadlines.

@spier
Copy link
Member

spier commented Mar 16, 2023

@fioddor I had misunderstood the "scope of change to process".

I had read it as "scope of change to the process" i.e. a process change.
Sorry about the confusion and please ignore that bit of my previous feedback.

Co-authored-by: Igor Zubiaurre <fioddor@gmail.com>
@Trueblueaddie Trueblueaddie requested review from fioddor and removed request for robtuley, NewMexicoKid, lenucksi and cewilliams March 23, 2023 23:21
Copy link
Contributor

@fioddor fioddor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor style glitches.

spier and others added 2 commits March 24, 2023 13:22
Co-authored-by: Igor Zubiaurre <fioddor@gmail.com>
Co-authored-by: Igor Zubiaurre <fioddor@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 Type - Content Work Working on contents is the main focus of this issue / PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants