Feat/ibc transfer module queries #164
Conversation
WalkthroughThe recent updates primarily involve the addition of JSON schema definitions for various blockchain functionalities, focusing on IBC transfer and Tendermint specifics. Additionally, there are cosmetic changes like line breaks in Markdown files and new JSON table conversions, all aimed at enhancing documentation and SDK support. Changes
Poem
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (51)
Files not summarized due to errors (1)
Files skipped from review due to trivial changes (14)
Additional comments not posted (284)
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| {"Parameter": "total", "Type": "Integer", "Description": ""}, | ||
| {"Parameter": "hash", "Type": "Bytes", "Description": ""} |
There was a problem hiding this comment.
Please provide descriptions for the "total" and "hash" parameters to clarify their roles and significance within the part set header.
| {"Parameter": "block", "Type": "Integer", "Description": ""}, | ||
| {"Parameter": "app", "Type": "Integer", "Description": ""} |
There was a problem hiding this comment.
Please provide descriptions for the "block" and "app" parameters to clarify their roles and significance within the consensus data.
| @@ -0,0 +1,4 @@ | |||
| [ | |||
| {"Parameter": "hash", "Type": "Bytes", "Description": "Block hash"}, | |||
| {"Parameter": "part_set_header", "Type": "PartSetHeader", "Description": ""} | |||
There was a problem hiding this comment.
Please provide a description for the "part_set_header" parameter to clarify its role and significance within the block ID.
| [ | ||
| {"Parameter": "data", "Type": "Bytes", "Description": "Query data", "Required": "No"}, | ||
| {"Parameter": "path", "Type": "String", "Description": "Query path", "Required": "Yes"}, | ||
| {"Parameter": "haight", "Type": "Integer", "Description": "Block height", "Required": "No"}, |
There was a problem hiding this comment.
Fix the typo in the parameter name.
- {"Parameter": "haight", "Type": "Integer", "Description": "Block height", "Required": "No"}
+ {"Parameter": "height", "Type": "Integer", "Description": "Block height", "Required": "No"}Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| {"Parameter": "haight", "Type": "Integer", "Description": "Block height", "Required": "No"}, | |
| {"Parameter": "height", "Type": "Integer", "Description": "Block height", "Required": "No"}, |
| {"Parameter": "data", "Type": "Bytes", "Description": "Query data", "Required": "No"}, | ||
| {"Parameter": "path", "Type": "String", "Description": "Query path", "Required": "Yes"}, | ||
| {"Parameter": "haight", "Type": "Integer", "Description": "Block height", "Required": "No"}, | ||
| {"Parameter": "prove", "Type": "Boolean", "Description": "", "Required": "No"} |
There was a problem hiding this comment.
Add a description for the "prove" parameter to clarify its purpose.
| {"Parameter": "index", "Type": "Integer", "Description": ""}, | ||
| {"Parameter": "key", "Type": "Bytes", "Description": ""}, | ||
| {"Parameter": "value", "Type": "Bytes", "Description": ""}, | ||
| {"Parameter": "proof_ops", "Type": "ProofOps", "Description": ""}, |
There was a problem hiding this comment.
Add a description for the "proof_ops" parameter to clarify its purpose.
| {"Parameter": "value", "Type": "Bytes", "Description": ""}, | ||
| {"Parameter": "proof_ops", "Type": "ProofOps", "Description": ""}, | ||
| {"Parameter": "height", "Type": "Integer", "Description": "Block height"}, | ||
| {"Parameter": "codespace", "Type": "String", "Description": ""} |
There was a problem hiding this comment.
Add a description for the "codespace" parameter to clarify its purpose.
| @@ -0,0 +1,10 @@ | |||
| [ | |||
| {"Parameter": "protocol_version", "Type": "ProtocolVersion", "Description": "Protocol version information"}, | |||
| {"Parameter": "default_nod_id", "Type": "String", "Description": "Node identifier"}, | |||
There was a problem hiding this comment.
Fix the typo in the parameter name.
- {"Parameter": "default_nod_id", "Type": "String", "Description": "Node identifier"}
+ {"Parameter": "default_node_id", "Type": "String", "Description": "Node identifier"}Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| {"Parameter": "default_nod_id", "Type": "String", "Description": "Node identifier"}, | |
| {"Parameter": "default_node_id", "Type": "String", "Description": "Node identifier"}, |
| {"Parameter": "network", "Type": "String", "Description": "The chain network name"}, | ||
| {"Parameter": "version", "Type": "String", "Description": "The version number"}, | ||
| {"Parameter": "channels", "Type": "Bytes", "Description": "Channels information"}, | ||
| {"Parameter": "moniker", "Type": "String", "Description": ""}, |
There was a problem hiding this comment.
Add a description for the "moniker" parameter to clarify its purpose.
| - Updated the API documentation to include all queries and messages for the `tendermint` module | ||
| - Python SDK v1.5.0 | ||
| - Added support for all queries from the `tendermint` module | ||
| - Added support for all queries from the `IBC transfer` modulee |
There was a problem hiding this comment.
Fix the typo in the changelog entry.
- - Added support for all queries from the `IBC transfer` modulee
+ - Added support for all queries from the `IBC transfer` moduleCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| - Added support for all queries from the `IBC transfer` modulee | |
| - Added support for all queries from the `IBC transfer` module |
NOTE: Do not merge this PR until Python SDK v1.5.0 is released in master
Solves CHAIN-76
Summary by CodeRabbit
New Features
tendermintandIBC transfermodules in the Python SDK v1.5.0.ibctransferandtendermintin the documentation index.Documentation
Style