Fix: Groups support for Secret Approvals and Access Requests #1773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhilmhdh
requested changes
May 3, 2024
| t.foreign("approverUserId").references("id").inTable(TableName.Users).onDelete("CASCADE"); | ||
| }); | ||
|
|
||
| await knex.schema.alterTable(TableName.SecretApprovalRequest, (t) => { |
There was a problem hiding this comment.
I was testing identity for secret replication and issue is then i would need to add all these fields again . May be instead we do it like permission there is non nullable - `type"which says whether its user or identity and keep rest as generic like before
Then do a conditional join
There was a problem hiding this comment.
Kindly make the migration file idempotent
backend/src/ee/services/access-approval-request/access-approval-request-dal.ts
Outdated
Show resolved
Hide resolved
backend/src/ee/services/access-approval-request/access-approval-request-dal.ts
Outdated
Show resolved
Hide resolved
backend/src/db/migrations/20240429172301_access_approval_requests.ts
Outdated
Show resolved
Hide resolved
…sical into daniel/fix-db-ref
DanielHougaard
force-pushed
the
daniel/request-access
branch
2 times, most recently
from
06871fc
to
9a585ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.