Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolved cli offline mode get #1757

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

fix: resolved cli offline mode get #1757

wants to merge 16 commits into from

Conversation

sheensantoscapadngan
Copy link
Member

@sheensantoscapadngan sheensantoscapadngan commented Apr 29, 2024 •
edited

Description 📣

  • resolved offline mode issues in the following:
    -- infisical secrets
    -- infisical run

  • modified the structure of the tests so that there's a single point of entry before all the integration tests (so that we can do setups).

  • developed a bash script to parse .test.env files and add them as shell ENVs (making test setup easier in the local environment)

  • added integration tests for secretsGetAll as well as secretsGetAllWithoutConnection

image

Type ✨

  • Bug fix
  • New feature
  • Breaking change
  • Documentation

Tests 🛠️

# Here's some code block to paste some code snippets

akhilmhdh
akhilmhdh previously approved these changes Apr 29, 2024
View reviewed changes
@akhilmhdh akhilmhdh requested a review from maidul98 April 29, 2024 15:03
@sheensantoscapadngan
Copy link
Member Author

sheensantoscapadngan commented Apr 30, 2024 •
edited

perform infisical login step before running integration tests

  • need to somehow mock CLI interactions during login (or add support for flags that allow us to do logins as one command (?))

@maidul98 maidul98 requested review from DanielHougaard and akhilmhdh and removed request for maidul98 and akhilmhdh May 1, 2024 15:31
DanielHougaard
DanielHougaard requested changes May 1, 2024
View reviewed changes
Copy link
Collaborator

@DanielHougaard DanielHougaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! I left a few comments for you!

.github/workflows/run-cli-tests.yml Show resolved Hide resolved
cli/packages/util/secrets.go Show resolved Hide resolved
cli/scripts/export_test_env.sh Show resolved Hide resolved
cli/test/helper.go Show resolved Hide resolved
cli/test/main_test.go Show resolved Hide resolved
DanielHougaard
DanielHougaard previously approved these changes May 1, 2024
View reviewed changes
@sheensantoscapadngan sheensantoscapadngan mentioned this pull request May 14, 2024
Open
@akhilmhdh akhilmhdh linked an issue May 14, 2024 that may be closed by this pull request
Offline functionality not working as expected #1639
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akhilmhdh akhilmhdh akhilmhdh left review comments

@DanielHougaard DanielHougaard DanielHougaard left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Offline functionality not working as expected
3 participants
@sheensantoscapadngan @akhilmhdh @DanielHougaard