Fix: Machine Identities user experience improvement #1718
+82
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maidul98
requested review from
dangtony98 and
vmatsiiako
and removed request for
vmatsiiako and
dangtony98
vmatsiiako
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
Previously we've been getting a lot of bug reports from people mixing up the identity ID and client ID, which is very understandable since we display the ID of the identity on the identity row. The ID's are both UUID format, which makes it even easier to mix them up.
In this PR I've introduced a new dropdown menu where the "Delete identity", "Update identity", and "Copy internal ID" now lives.
Type ✨