Explaining mean in tasks.json #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
nickreich
reviewed
Mar 28, 2024
| @@ -98,11 +98,11 @@ Now, read below for details on some of the lines of code in this file: | |||
| ``` | |||
|
|
|||
| ### 5.5. Defining [`"output_type"`](#model_output_format): | |||
| - The [`output_type`](#model_output_format) is used to establish the valid model output types for a given modeling task. In this example they include `mean` and `quantile`. | |||
| - The [`output_type`](#model_output_format) is used to establish the valid model output types for a given modeling task. In this example they include `mean` and `quantile`, but `median`, `cdf`, `pmf`, and `sample` are other supported output types. Output types have two additional properties, an `output_type_id` and a `value` property, both of which establish the valid values that can be entered for this output type. | |||
There was a problem hiding this comment.
Not a request for a change here, but flagging that based on ongoing work on sample output types, we might eventually change this so that there would be an output_type_id_params argument in there as well.
nickreich
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
I think these changes are good. made one comment about something that will possibly need to be updated later, but otherwise, LGTM! I had flagged @annakrystalli as a reviewer too, but I think that is not needed, as the scope of changes here is minimal.
nickreich
merged commit 2cceb73
into
Infectious-Disease-Modeling-Hubs:main
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding explanations to address #99 .