#68 fixing import directives #69
Conversation
Sealdolphin
commented
Jun 22, 2022
Sealdolphin
commented
- Changed name of import libraries
source/incqueryserver-jupyter/iqs_jupyter/analysis_extensions.py
Outdated
Show resolved
Hide resolved
| if 'MmsRepositoryApi' in dir(iqs_client): | ||
| from iqs_jupyter.mms_extensions import * | ||
| from iqs_jupyter.mms_direct_extensions import * | ||
| #if 'MmsRepositoryApi' in dir(iqs_client): |
There was a problem hiding this comment.
I understand that we no longer ship trimmed down versions of the core API, but is there any specific need to remove these conditionals? I would expect them to work just fine.
There was a problem hiding this comment.
I found it inconsistent, because the new generator creates a different architecture... If we want it to stay, we may change it, but I thought it was easier for now to omit these features. This is a work in progress.
There was a problem hiding this comment.
Have we changed which openapi generator we use? Is there a specific reason why we instituted such a change? Does it otherwise generate better client code?
There was a problem hiding this comment.
Yes, the new version is generated using a gradle plugin, instead of a library.
There was a problem hiding this comment.
No, I mean OpenAPI (whether invoked from the CLI or via Gradle) has a selection of plugins called "generators". Are we still using the same one?
There was a problem hiding this comment.
@bergmanngabor - We would like to upgrade OpenApi generator to 5.x project-wise in IQS, I think it is reasonable to use newer version, because later we might face issues caused by the outdated generator.
|
It seems, that out Open API generator causes many issues in the client, which may break this extension. Therefore we do not upgrade the Open API version for now. The old version (4.2.3.) stays instead. This means, that this issue becomes irrelevant. |
