Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support building plugins without ltdl #6940

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Redfoxymoon
Copy link

@Redfoxymoon Redfoxymoon commented Dec 12, 2023

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practices as demonstrated in the repository.

Description

support building imagemagick with shared modules without using ltdl, allows building imagemagick with slibtool and for platforms that ltdl does not support

missing configure changes

@dlemstra
Copy link
Member

Not sure if we should support this? Do you have examples of platforms where this now doesn't work? And if we do this it might be better to create new defines that either use dlclose or lt_dlclose and do the same for the other methods like dlerror?

@Redfoxymoon
Copy link
Author

Redfoxymoon commented Dec 12, 2023

Midipix, a POSIX layer for microsoft windows lacks support for ltdl, we already have imagemagick running there with dynamic plugins. update: slibtool supports (s)ltdl

a set of macros would remove the need for most of the ifdef preprocessor changes, true; that's another option

@dlemstra
Copy link
Member

This would also require changes to the configure.ac file to detect either libltdl or dlfcn and sets flags accordingly. And I think libltdl should be preferred when that could be found.

@Redfoxymoon
Copy link
Author

Redfoxymoon commented Dec 13, 2023

Defaulting to libltdl would be fine - alternatively a set of --enable/--disable- configure options?

@orbea
Copy link

orbea commented Mar 17, 2024

@dlemstra Would this be acceptable with a set of --enable/--disable configure flags as suggested by @Redfoxymoon?

This would be helpful on Gentoo when using slibtool instead of GNU libtool which doesn't install the libtool archive (.la) files by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants