Carousel Component with Three Images #273
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…IllinoisWCS/IllinoisWCS.github.io into sv/main-page-styling merge branch that implements fix for computer window
neha-vard
requested changes
Feb 25, 2024
There was a problem hiding this comment.
This looks really awesome Nancy, love the transitions! We know this wasn't in the initial design, but we were wondering if you could add arrows to the front window, maybe with < and > icons, so it is more clear to the user that they can scroll through the images. Also, maybe we can have the back images lower than the front image, like in this design?
Lastly, it would be great if you could resolve the merge conflicts. Let us know if you have any questions/concerns!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status: Ready
Description
Reformatted images to be an image carousel consisting of three images. Can click to transition between images.
Addresses #247
Screenshots