Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security enhancement through salting #192

Open
FrostyPenguin opened this issue Aug 13, 2019 · 1 comment
Open

Security enhancement through salting #192

FrostyPenguin opened this issue Aug 13, 2019 · 1 comment

Comments

@FrostyPenguin
Copy link

Hey, I just noticed that the passwords are stored in plain-hashed format using sha256.
First off, it's awesome that it doesn't just store them in plain. However, when two users have the same password this results in the very same hash.

That's why in “real” OSes they salt the password. A two digit number that is prepended to the password before hashing and stored in plain alongside the hash is enough to make the system an awful lot stronger 😏.

I'd open a pull request if I was better in Lua programming (I'm a C fanboy). So if someone wants to give this a try before I do (probably not very soon), feel free to do so.

@IgorTimofeev
Copy link
Owner

Good point, maybe someday this will be added, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants