*nix script build-all.py improved: solves the Issues #637 (segmentation fault 11) for Mac OS X #643
Conversation
Improvements: - use of system installed python in the build-all.py script for Mac OS X - reverted to the use of swig 3.0.12 for the time being becaue swig version 4.0 causes error in the build process with Mac OS X - use of the to_pystring() was minimized
nix/build-all.py
Outdated
| download_tool_git = "git" | ||
|
|
||
| if which(wget) != None: |
There was a problem hiding this comment.
Is there a reason why you re-enabled this related to wget and curl? Or was it a merge error?
There was a problem hiding this comment.
I didn't touch this part specifically. But, the code looks ok, right?
There was a problem hiding this comment.
I didn't touch this part specifically.
Then it was probably a merge error.
But, the code looks ok, right?
These bits of code were removed recently (on Jun 30: 51cf52c) wget was giving issues on older distros due to all the changes in certificates and TLS recently. But now you're adding them back in your pull request.
I hope you can review the changes in your PR and remove the unintentional and whitespace changes. If you have time for making your change conditional that would be great as well. Let me know, I can also assist.
|
Many thanks for this. I'll need to have a look with |
Yes, this would be better approach. I can do the change and commit again. |
…, some whitespaces corrected
* 'v0.6.0' of github.com:atibaut/IfcOpenShell: Only pull when on a branch -pthread on unix fix po::value Threads in python app Cleanup concurrently created breps and triangulations Write progress for threaded conversion Some fixes to threading work Implement multi_threaded implementation in Iterator Last commit for multithreading, Airsquire implementation Sander boer's change for multithreading 1. Added multithread for create element 2. Added support function in IfcConvert.cpp for multithreading at bottom .clang-format settings indent=2 for me, temporarily. style=allman width=80 builds nicely, but chokes immediately on serializer- first element, needs debugging Linearizing the use of IfcGeomIterator by integrating it into IfcConvert in full, atm it does not build. merge with ifcopenshell Too lazy to comment
|
First part resolved (whitespaces, unintentional wget, renamed back to build_dependencies). Second part (conditional use of system python, example python3 build-all.py --use-system-python) will follow. |
|
OK, now after c497b89 I got following error: Has ifcParse.h been changed in between? |
|
Yes, support for multithreading was merged, and apparently clang isn't happy with it. I have added clang to the Travis testing environment, and indeed the same error is reported there https://travis-ci.org/IfcOpenShell/IfcOpenShell/jobs/569276027#L1022 Hope to have time tomorrow to address this. Thanks for reporting. |
|
clang on Travis is working again https://travis-ci.org/IfcOpenShell/IfcOpenShell/builds/569804898?utm_source=github_status&utm_medium=notification |
Example: python build-all.py --use_system_python
|
I think the Appveyor (for Win) Cmake error check has nothing to do with my commit. Can you check, please? |
|
@aothms can u check the AppVeyor build? |
|
@aothms can u please check the AppVeyor build and tell me what could possibly be wrong here? |
|
Will this PR be merged? |
|
@mudin can you check? Did it work for you? I don't have an OSX machine near me. Overall the changes look good to me. |
|
@aothms Still not working:
|
|
@mudin what's your version of XCode and OSX/macOS? Do you have installed additional compilers on your system? |
|
@aothms thank you for the response. |
|
@mudin do you have the complete log? Somewhere in IfcOpenShell/build/10.15/logs I think. Apparently something wrong with selection of compiler. |
Improvements: