New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quantity take offs in SI units #4166
base: v0.7.0
Are you sure you want to change the base?
Conversation
@theoryshaw do you want to modify only the qto in n-panel? |
Hi. Say again. Not sure i'm following you. |
@theoryshaw sorry i'm on mobile phone... i wanted to know if you want to modify only the behavior in the qto subpanel (that is located in the n-panel) or you want to modify also other panels... |
Gotcha, NP. Yes, it would be nice to have all QTO functionality throughout accommodate SI units. This PR is just a piece of more changes in the future.. some I 'might' be able to handle. Some I 'might' not be able to. :) |
@@ -25,11 +25,11 @@ def calculate_height(obj): | |||
|
|||
|
|||
def calculate_edges_lengths(objs, context): | |||
return calculate_mesh_quantity(objs, context, lambda bm: sum((e.calc_length() for e in bm.edges if e.select))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is if e.select
removed? Isn't that important to allow the user to select the relevant edges or faces to be calculated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bump @theoryshaw
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems resolved now - makes sense to check for selected edges only if you're in edit mode
Ping @Gorgious56 and @maxfb87
Does this look okay to you? If so, i can look into modifying
ExecuteQtoMethod
also.