Fixed #3829 occured after ae45e6b

similar_openings wasn't reset on each iteration causing moving unrelated openings
IfcOpenShell · Oct 2, 2023 · edaabf5 · edaabf5 · Andrej730 · Oct 2, 2023
1 parent ad79c63
commit edaabf5
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/src/blenderbim/blenderbim/bim/module/model/opening.py b/src/blenderbim/blenderbim/bim/module/model/opening.py
@@ -748,17 +748,14 @@ def _execute(self, context):
         building_objs = set()
         model = tool.Ifc.get()
         all_openings = model.by_type("IfcOpeningElement")
-        similar_openings = []
 
         for obj in context.selected_objects:
             element = tool.Ifc.get_entity(obj)
             if not element:
                 continue
             openings = [r.RelatedOpeningElement for r in element.HasOpenings]
             for opening in openings:
-                for all_opening in all_openings:
-                    if all_opening.ObjectPlacement == opening.ObjectPlacement:
-                        similar_openings.append(all_opening)
+                similar_openings = [o for o in all_openings if o.ObjectPlacement == opening.ObjectPlacement]
                 opening_obj = tool.Ifc.get_object(opening)
                 if opening_obj:
                     if tool.Ifc.is_edited(opening_obj):