Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font previews fixed and increased resolution #189

Open
wants to merge 2 commits into
base: test
Choose a base branch
from

Conversation

albanafmeti
Copy link

Resolves #155

@ghost ghost assigned albanafmeti Aug 30, 2018
@ghost ghost added the in progress label Aug 30, 2018
@kominoshja
Copy link

@elioqoshi your feedback is needed here: https://identihub.budini.xyz/a#/

@elioqoshi
Copy link
Contributor

elioqoshi commented Sep 1, 2018

Thanks! Much better. Can we have a bit more margin like it used to?
Now:
image

Should be:
image

Also in Gallery view, can you remove the border?

image

Otherwise good to go

@albanafmeti
Copy link
Author

@kominoshja check now please.

@kominoshja
Copy link

@elioqoshi seems good?

@elioqoshi
Copy link
Contributor

I can't access the test instance where it is live but if it's fixed accordingly, it should be good to go.

@kominoshja
Copy link

You can test it here: https://identihub.budini.xyz/aa#/

@elioqoshi
Copy link
Contributor

Thanks.

Margin is still not consistent:
image

It should be more like this (moved a bit to the right):
image

Also can this be optimized for mobile a bit more?

Currently it looks like this:
image

Can the box be adapted to the font preview? So there is no unncessary margin, like this:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants