Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import Inkscape Color Swatches #76 #140

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Import Inkscape Color Swatches #76 #140

wants to merge 3 commits into from

Conversation

budaaaa
Copy link
Contributor

@budaaaa budaaaa commented May 16, 2018 •
edited

  • Added the ability to upload gpl files
  • Validated from frontend to accept only GPL files throwing error on anything else
  • Refactored tag to accept multiple < li > dynamically
  • Fixed error with text areas
  • Fixed error with updating text input
  • Overall refactor
  • fixed URL on close redirect

@budaaaa
Import Inkscape Color Swatches Identihub#76
c5ce3ca 
- Added the ability to upload gpl files
- Validated from frontend to accept only GPL files throwing error on anything else
- Refactored <SectionWrapper /> tag to accept multiple <li> dynamically
@budaaaa
Import Inkscape Color Swatches Identihub#76
ec868ac 
- Added the ability to upload gpl files
- Validated from frontend to accept only GPL files throwing error on anything else
- Refactored <SectionWrapper /> tag to accept multiple <li> dynamically
- Fixed error with text areas
- Fixed error with updating text input
- Overall refactor
@budaaaa
Import Inkscape Color Swatches Identihub#76
aa728ff 
- fixed URL on close redirect
@ghost ghost assigned budaaaa May 16, 2018
@ghost ghost added the 4. in progress This issue is being worked on label May 16, 2018
@budaaaa budaaaa mentioned this pull request May 16, 2018
Open
@kominoshja
Copy link

Thanks for this @budaaaa. Will review it and get back to you!

@elioqoshi
Copy link
Contributor

@Borisbudini reminder

@kominoshja kominoshja removed the request for review from sidis405 June 15, 2018 13:15
@kominoshja
Copy link

Seems like I did not properly click 'Comment' last time.
While testing this feature, it seemed that Identihub would only accept files with the exact spacing as below. From what i can understand, we need a parser before merging this feature
248 249 250

Taken from this file

@budaaaa budaaaa mentioned this pull request Aug 1, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kominoshja kominoshja Awaiting requested review from kominoshja

Assignees
No one assigned
Labels
4. in progress This issue is being worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@budaaaa @kominoshja @elioqoshi