Fix ITL for http CheckCommand definition #9974
Conversation
tbauriedel
force-pushed
the
fix/itl-http-definition
branch
from
a1ea15d
to
e8e47dd
Compare
|
@Al2Klimov FYI: looks like there's a problem with the AUTHORS file workflow, possibly related to the PR coming form an external repo. |
There were some missing arguments. ref/NC/806131
Al2Klimov
force-pushed
the
fix/itl-http-definition
branch
from
ba43744
to
5d78c08
Compare
|
Any updates here? |
| @@ -423,8 +427,13 @@ object CheckCommand "http" { | |||
| } | |||
| "-C" = { | |||
| value = "$http_certificate$" | |||
| description = "Minimum number of days a certificate has to be valid. This parameter explicitely sets the port to 443 and ignores the URL if passed." | |||
| description = "Minimum number of days a certificate has to be valid. This parameter explicitely sets the port to 443 and ignores the URL if passed" | |||
There was a problem hiding this comment.
The removed . produces unnecessary diffs, please revert it.
There was a problem hiding this comment.
Shouldn't the "description syntax" be unique? The sentences end without a '.' in the other arguments.
I can remove it, but then it will never be standardized.
itl/command-plugins.conf
Outdated
| description = "Minimum number of days a certificate has to be valid. This parameter explicitely sets the port to 443 and ignores the URL if passed" | ||
| } | ||
| "--continue-after-certificate" = { | ||
| value = "$http_certificate_continue$" |
There was a problem hiding this comment.
Since this option is a boolean flag, please use set_if instead of value. Icinga 2 will then only pass this argument if it is explicitly set to true.
itl/command-plugins.conf
Outdated
| } | ||
|
|
itl/command-plugins.conf
Outdated
| "-U" = { | ||
| value = "$http_showurl$" | ||
| description = "Print URL in msg output in plain text" | ||
| } |
There was a problem hiding this comment.
Where did you get that option from? As far as I can see, there is no such option listed in the plugin documentation.
| @@ -360,6 +360,10 @@ object CheckCommand "http" { | |||
| value = "$http_vhost$" | |||
| description = "Host name argument for servers using host headers (virtual host)" | |||
| } | |||
| "--extra-opts" = { | |||
| value = "$http_extra_opts$" | |||
There was a problem hiding this comment.
This option should probably use set_if as well, as there is no need to look for extra options if not explicitly requested by the user.
There were some missing arguments.
CheckCommand definition adapted to the current status of the plugin.
ref/NC/806131