Fix broken downtime comment sync #10000
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync all objects in priority descending order, otherwise downtimes, comments etc. might be synced before their respective checkables, which would result in comments/downtimes being ignored by the other endpoint since it doesn't yet know about their checkables. Since the runtime config updates event doesn't trigger a reload on the remote endpoint, theses objects won't be synced again til the next reload.
yhabteab
added
bug
Al2Klimov
requested changes
Feb 13, 2024
| // trigger a reload on the remote endpoint, these objects won't be synced again til the next reload. | ||
| std::vector<Type::Ptr> types = Type::GetAllTypes(); | ||
| std::sort(types.begin(), types.end(), [](const Type::Ptr& a, const Type::Ptr& b) { | ||
| return a->GetActivationPriority() > b->GetActivationPriority(); |
There was a problem hiding this comment.
Better call Type#GetLoadDependencies().
There was a problem hiding this comment.
What is Type#GetLoadDependencies() supposed to bring me here? It would be nice if you could explain in more detail why you think activation priority is not right instead of simply suggesting "better call Type#GetLoadDependencies()".
There was a problem hiding this comment.
Activation priority is just about in which order objects start doing things. In contrast, Type#GetLoadDependencies() reflects the load_after T; we discussed offline. It fetches the types which must be loaded before the given type.
There was a problem hiding this comment.
Theoretically we could even merge
instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync all objects in activation priority descending order, otherwise downtimes,
comments etc. might be synced before their respective checkables, which
would result in comments/downtimes being ignored by the other endpoint
since it doesn't yet know about their checkables. Since the runtime
config updates event doesn't trigger a reload on the remote endpoint,
theses objects won't be synced again til the next reload/reconnect.
After master2 reload:
closes #7786
closes #9873