Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bring toIQMPO, toIQ back to work #95

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bring toIQMPO, toIQ back to work #95

wants to merge 1 commit into from

Conversation

xichuang
Copy link
Contributor

@xichuang xichuang commented Apr 8, 2016

Update toIQMPO(), toIQ(), convertToIQ() to itensor version 2 .
Those codes are based on the original codes in v1, and tested with the programs in fold samples by substituting
auto H = IQMPO(ampo)

with

auto A = MPO(ampo); auto H = A.toIQMPO();
which give the same results.

@emstoudenmire
Copy link
Contributor

Hi, thanks for contributing this and sorry it's been so long. Part of the issue is that while this functionality is nice to have, I wasn't sure about maintaining it myself and supporting it as a core part of ITensor. The toIQMPO feature was always a tricky because it relies on a lot of heuristics such as when to treat a very small number as exactly zero, etc. So I had quietly stopped supporting it in the new version. But people may still benefit from it in certain cases.

So we came up with a new way for people to contribute complex, somewhat experimental codes like these. We now have a "Codes" page on the ITensor site: http://itensor.org/codes
If you post your toIQMPO code in its own repo on Github, we will be glad to link to it and list you as the maintainer. Then people can use it for their own projects, we can all observe if the code is working well, and then possibly decide to include it in ITensor later. In some sense, it is like a set of "plugins" for ITensor, similar to Julia or python packages.

Please let me know what you think about posting your toIQMPO implementation as a separate code this way - thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants