Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extension of svd routine to include solver ?gesdd from lapack #179

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jurajHasik
Copy link

@jurajHasik jurajHasik commented Nov 8, 2018

This is initial commit for extension of svd solver as implemented in ITensor. User can
pass a parameter to svd function inside Args container specifying method to use.

an example call: svd(A,U,V,D,{"SVDMethod","gesdd"})

if Args do not contain "SVDMethod" parameter, the default ITensor implementation of svd
solver is used. No change to calls of svd already defined anywhere in the code is necessary.

The extension is implemented at low level. A function SVDRef (defined in tensor/algs.cc)
serves as a fork. It checks for a presence of "SVDMethod" parameter in the Args. If not
found a default ITensor svd is called. Otherwise, a particular implementation identified
through string, in this case "gesdd" is called. The actual implementation of the solver
is given in a file tensor/extra-svds.cc. It performs the call to lapack ?gesdd routine.

The unit tests are included in file unittests/extra-svds_test.cc

Note: possibly column-major to row-major conversion for output VT of ?gesdd might be avoided ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant