Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Use docker stack config #610

Merged
merged 4 commits into from
Mar 19, 2024
Merged

Fix: Use docker stack config #610

merged 4 commits into from
Mar 19, 2024

Conversation

mrnicegyu11
Copy link
Member

@mrnicegyu11 mrnicegyu11 commented Mar 19, 2024 •
edited

What do these changes do?

We have been using custom hackery to mitigate that docker compose config is not compatble with docker swarm.

Luckily, the docker guys have a new command that works: docker stack config. This PR adapts our deploy-scripts to use this, in line with docker/compose#9306 (comment)

During the docker engine update on dalco this surfaced, since deploying docker stacks to dalco was not possible anymore with our previous tooling. I really dont know why it continued to work on aws-master, etc. I am still trying to reproduce on that end.

CC @sanderegg how are you currently handling this in simcore?

Bonus:
Fully deprecates docker-compose v1.

Related issue/s

https://git.speag.com/oSparc/osparc-ops-deployment-configuration/-/jobs/4689324 failed CD run, reproducible, I traces this to the docker compose issue mentioned above

Related PR/s

Checklist

  • I tested and it works

@mrnicegyu11 mrnicegyu11 self-assigned this Mar 19, 2024
@mrnicegyu11 mrnicegyu11 added t:bug Something isn't working p:high-prio labels Mar 19, 2024
@mrnicegyu11 mrnicegyu11 added this to the Schoggilebe milestone Mar 19, 2024
@mrnicegyu11 mrnicegyu11 marked this pull request as ready for review March 19, 2024 10:54
@mrnicegyu11 mrnicegyu11 changed the title Fix: Use docker compose config Fix: Use docker stack config Mar 19, 2024
sanderegg
sanderegg approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few questions. looks great.

scripts/docker-compose-config.bash Show resolved Hide resolved
@mrnicegyu11 mrnicegyu11 merged commit fbe3eed into ITISFoundation:main Mar 19, 2024
3 checks passed
@mrnicegyu11 mrnicegyu11 deleted the fix/dockercomposeBashRegex branch March 19, 2024 11:24
mrnicegyu11 pushed a commit that referenced this pull request Mar 21, 2024
Revert "Try to fix CD - 3"
945b576 
This reverts commit d2f9f9b.

Revert "Try to fix CD - 2"

This reverts commit 4fc7910.

Revert "Try to fix CD - 1"

This reverts commit 126671f.

Revert "Fix: Use `docker stack config` (#610)"

This reverts commit fbe3eed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderegg sanderegg sanderegg approved these changes

@YuryHrytsuk YuryHrytsuk Awaiting requested review from YuryHrytsuk YuryHrytsuk is a code owner

Assignees

@mrnicegyu11 mrnicegyu11

Labels
p:high-prio t:bug Something isn't working
Projects
None yet
Milestone
Schoggilebe
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mrnicegyu11 @sanderegg