Git and help icon buttons #731
Conversation
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
client/src/page/MenuToolbar.tsx
Outdated
| @@ -88,8 +90,22 @@ function MenuToolbar({ | |||
| </Typography> | |||
|
|
|||
| <Box sx={{ flexGrow: 0 }}> | |||
| <IconButton | |||
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
client/src/page/MenuToolbar.tsx
Outdated
| > | ||
| <GitHubIcon fontSize="inherit"></GitHubIcon> | ||
| </IconButton> | ||
| <IconButton |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
|
@VanessaScherma please revert tge changes done to: package.json and .pre-commit.yaml files. |
| @@ -78,3 +93,12 @@ describe('LinkButtons component with specified size', () => { | |||
| evaluateButtonSize(customSize); | |||
| }); | |||
| }); | |||
|
|
|||
| describe('LinkButtons component with specified marginRight', () => { | |||
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
There was a problem hiding this comment.
@VanessaScherma, thanks for the updates. Please check the comments.
client/yarn.lock
Outdated
There was a problem hiding this comment.
please revert changes to this file.
| }); | ||
|
|
||
| interface IconButtonData { | ||
| link: string; | ||
| icon: React.ReactElement; | ||
| name: string; | ||
| name: string | undefined; |
There was a problem hiding this comment.
Why do we need undefined here?
There was a problem hiding this comment.
This is needed because we decided to leave the NO_ICON (in LinkIconsLib.tsx) with the undefined name.
There was a problem hiding this comment.
We talked about using topmenu as names / prefix for the icons. Please use code-github and help as icon names.
|
Code Climate has analyzed commit bb79455 and detected 0 issues on this pull request. View more on Code Climate. |
prasadtalasila
merged commit e53beb2
into
INTO-CPS-Association:feature/distributed-demo
Git and help icons added on MenuToolbar.