Session storage clear+oidc silent logout/token revoke+traefik url HTTP GET request to logout of server #681
Conversation
…P GET request to logout of server
…ture/distributed-demo
| await auth.revokeTokens(); | ||
|
|
||
| // Make HTTP GET call to logout URL | ||
| await fetch(`${process.env.REACT_APP_URL}/_oauth/logout`, { |
There was a problem hiding this comment.
@raiiasingh19
Some of the installation scenarios don't have a server listening at this address. If not the fetch might throw an error. You might want to write a promise with enough code to handle the exceptions. There might be some in the fetch as well. Please check.
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| }); | ||
| } | ||
|
|
||
| export async function signOut(userManager: UserManager) { |
There was a problem hiding this comment.
Function signOut has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
| }); | ||
| } | ||
|
|
||
| export async function signOut(userManager: UserManager) { |
There was a problem hiding this comment.
Function signOut has 41 lines of code (exceeds 25 allowed). Consider refactoring.
| }); | ||
| } | ||
|
|
||
| export async function signOut(userManager: UserManager) { |
There was a problem hiding this comment.
Function signOut has 40 lines of code (exceeds 25 allowed). Consider refactoring.
| }); | ||
| } | ||
|
|
||
| export async function signOut(userManager: UserManager) { |
There was a problem hiding this comment.
Function signOut has 44 lines of code (exceeds 25 allowed). Consider refactoring.
| client_secret: clientSecret, | ||
| }; | ||
|
|
||
| await fetch(`${process.env.REACT_APP_URL}/_oauth/logout`, { |
There was a problem hiding this comment.
The signout happens via a GET request to this end point. There is no need for a request body. The required information goes via the headers. Please try developer setup and then check localhost/_oauth/logout. Remember to change the the line-11 of libms.dockerfile to
COPY ./deploy/config/lib.docker .
You can then use the browser developer tools to check the headers going to the servers.
|
Perhaps bringing out the server logout to a separate function will remove the codeclimate issues. @atomicgamedeveloper The recent comments are valid for PR #793 too. |
|
Code Climate has analyzed commit 3538d4a and detected 0 issues on this pull request. View more on Code Climate. |
Fixes #654 and #479