Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display relevant OAuth information on accounts page #499

Open
wants to merge 5 commits into
base: feature/distributed-demo
Choose a base branch
from

Conversation

anshhhhhhh
Copy link

No description provided.

</>
),
},
{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

client/src/route/auth/AccountTabs.tsx Show resolved Hide resolved
Copy link
Contributor

@prasadtalasila prasadtalasila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broader comments:

  1. There does not seem to be any change on the profile pages. Please check.
  2. The codeclimate issues need to be resolved

label: 'Profile',
body: (
<>
Profile - potentially visible to other users.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove these two lines

<br></br>
See more details on{' '}
<a href={auth.user?.profile.profile}>SSO OAuth provider.</a>
</>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the groups text and code here. The exact text is available in issue #478

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have added it in the conditional when the user is part of group/groups, this is the accounTabs constant content when he is not part of any of them

client/yarn.lock Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There aren't any changes in the package.json dependencies. Is there any particular reason for updating this file?

client/src/route/auth/AccountTabs.tsx Show resolved Hide resolved
@anshhhhhhh anshhhhhhh reopened this Mar 29, 2024
body: <>Account settings - private to a user.</>,
},
];
function AccountTabs() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function AccountTabs has 38 lines of code (exceeds 25 allowed). Consider refactoring.

@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2024

Codecov Report

Merging #499 (5093940) into feature/distributed-demo (bf079f0) will increase coverage by 2.29%.
Report is 3 commits behind head on feature/distributed-demo.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                     Coverage Diff                      @@
##           feature/distributed-demo     #499      +/-   ##
============================================================
+ Coverage                     63.38%   65.67%   +2.29%     
============================================================
  Files                            31       31              
  Lines                           396      405       +9     
  Branches                         26       31       +5     
============================================================
+ Hits                            251      266      +15     
+ Misses                          130      124       -6     
  Partials                         15       15              
Files Coverage Δ
client/src/route/auth/AccountTabs.tsx 100.00% <100.00%> (+100.00%) ⬆️
Components Coverage Δ
Website 65.67% <100.00%> (+2.29%) ⬆️
Lib Microservice ∅ <ø> (∅)

Copy link

codeclimate bot commented Mar 30, 2024

Code Climate has analyzed commit 5093940 and detected 0 issues on this pull request.

View more on Code Climate.

@prasadtalasila
Copy link
Contributor

@anshhhhhhh you added the number of groups a user belongs to. Listing of these user groups is needed instead. Thanks.

@prasadtalasila
Copy link
Contributor

@anshhhhhhh
The Account.tsx and its test code has been updated in the latest commit on feature/distributed-demo. Please port your changes onto that branch. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants